[PATCH] Added preliminary support for Netstal HCU4 board

[Josh Boyer]

On Thu, 2 Oct 2008 00:14:19 +0200
Niklaus Giger <niklaus.giger at member.fsf.org> wrote:

> Am Mittwoch 01 Oktober 2008 20.08:35 schrieb Josh Boyer:
> > On Wed, Oct 01, 2008 at 07:47:16PM +0200, Niklaus Giger wrote:
> > >Adds preliminary support for a HCU4 PPC405GPr based board from
> > >Netstal Maschinen AG.
> > >
> > >For the last 3 years I have been the only user running Linux on this
> > > board, but it served me well as testbed for the xenomai realtime
> > > extension to the Linux kernel.
> >
> > Overall, really nice for a first submission.
> One never has a second chance to make a first imrpession.
> 
> It was easy to make the needed changes (except changing ibm -> amcc, see 
> below). The dtc does the conversion from the old to the new format dts-v1 
> without a hitch. Calling "dtc -I dts -O dts hcu5.dts.old >hcu5.dts.new"l
> 
> My board is now in even better shape than before as I discovered that in my 
> dts I even wrongly overwrote a the speed variable for the early boot messages.
> Thanks a lot for suggestion!
> 
> > >+/ {
> > >+	#address-cells = <1>;
> > >+	#size-cells = <1>;
> > >+	model = "ibm,hcu4";
> > >+	compatible = "ibm,hcu4";
> >
> > These shouldn't be "ibm,hcu4".  IBM didn't make these boards.
> > Instead, you should make them "<company>,<board>", where
> > <company> is the company that made them (often the stock ticker
> > is used), and <board> is obviously hcu4 in this case.
> 
> Can you explain this a little bit more to me. When we started to fabricate our 
> boards we got the chips (or were it only the even older PPC403?) from IBM. If 
> I just replace in this dts file "ibm" by "amcc" my board does not boot anymore. 
> But if you give me a hint where and what I have to replace. I would volunteer 
> to clean it up (if it not too much work) a little bit.

No no.  I don't mean throughout the DTS file.  I just mean in the top
level model and compatible properties.  Those properties apply to the
overall board.  The CPU an ASCIs (EMAC, serial, etc) in the DTS are most
certainly from IBM, but your company actually manufactures the board.

So the top should be something like:

model = "netstal,hcu4";
compatible = "netstal,hcu4";

Everything else in the DTS looked fine in this regard as it is.

You will have to change your hcu4.c file to have:

	if (!of_flat_dt_is-compatible(root, "netstal,hcu4"))
		return 0;

and then it should be ok.

josh