[PATCH] Added preliminary support for Netstal HCU4 board

Niklaus Giger niklaus.giger at member.fsf.org
Thu Oct 2 08:14:19 EST 2008


Am Mittwoch 01 Oktober 2008 20.08:35 schrieb Josh Boyer:
> On Wed, Oct 01, 2008 at 07:47:16PM +0200, Niklaus Giger wrote:
> >Adds preliminary support for a HCU4 PPC405GPr based board from
> >Netstal Maschinen AG.
> >
> >For the last 3 years I have been the only user running Linux on this
> > board, but it served me well as testbed for the xenomai realtime
> > extension to the Linux kernel.
>
> Overall, really nice for a first submission.
One never has a second chance to make a first imrpession.

It was easy to make the needed changes (except changing ibm -> amcc, see 
below). The dtc does the conversion from the old to the new format dts-v1 
without a hitch. Calling "dtc -I dts -O dts hcu5.dts.old >hcu5.dts.new"l

My board is now in even better shape than before as I discovered that in my 
dts I even wrongly overwrote a the speed variable for the early boot messages.
Thanks a lot for suggestion!

> >+/ {
> >+	#address-cells = <1>;
> >+	#size-cells = <1>;
> >+	model = "ibm,hcu4";
> >+	compatible = "ibm,hcu4";
>
> These shouldn't be "ibm,hcu4".  IBM didn't make these boards.
> Instead, you should make them "<company>,<board>", where
> <company> is the company that made them (often the stock ticker
> is used), and <board> is obviously hcu4 in this case.

Can you explain this a little bit more to me. When we started to fabricate our 
boards we got the chips (or were it only the even older PPC403?) from IBM. If 
I just replace in this dts file "ibm" by "amcc" my board does not boot anymore. 
But if you give me a hint where and what I have to replace. I would volunteer 
to clean it up (if it not too much work) a little bit.

I cannot test on all boards but I have a walnut, yosemite and sequoia board at 
hand. Therefore I would be more confident to limit the cleanup to these boards.
(But only after my vacation, e.g. after the 20 of october).

Would you accept in the mean time a patch which still refers to "ibm,uic"?

Best regards

Niklaus




More information about the Linuxppc-dev mailing list