powerpc: hv{cs, si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative

Andreas Schwab schwab at suse.de
Sun Nov 30 02:01:47 EST 2008


roel kluin <roel.kluin at gmail.com> writes:

> Andreas Schwab wrote:
>> roel kluin <roel.kluin at gmail.com> writes:
>> 
>>> -	if (--hvcsd->open_count == 0) {
>>> +	if (hvcsd->open_count == 1) {
>>> +		hvcsd->open_count--;
>> 
>> This is not the same.
>
> I think you're missing that I also decrement if (hvcsd->open_count > 1)

Yes, sorry, I missed that.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab at suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the Linuxppc-dev mailing list