powerpc: hv{cs, si}_close() both unsigned hp->count and hvcsd->open_count cannot be negative

roel kluin roel.kluin at gmail.com
Sun Nov 30 00:27:16 EST 2008


Andreas Schwab wrote:
> roel kluin <roel.kluin at gmail.com> writes:
> 
>> -	if (--hvcsd->open_count == 0) {
>> +	if (hvcsd->open_count == 1) {
>> +		hvcsd->open_count--;
> 
> This is not the same.

I think you're missing that I also decrement if (hvcsd->open_count > 1)
If not, please elaborate.

> 
>> -	if (--hp->count == 0) {
>> +	if (hp->count == 1) {
>> +		hp->count--;
> 
> Likewise.

Same here.

Roel



More information about the Linuxppc-dev mailing list