[PATCH 3/5] powerpc: C2K board driver

Remi Machet rmachet at slac.stanford.edu
Sat May 17 02:01:32 EST 2008


On Fri, 2008-05-16 at 14:46 +1000, Stephen Rothwell wrote:
> Hi Remi,
> 
> On Thu, 15 May 2008 17:24:28 -0700 Remi Machet <rmachet at slac.stanford.edu> wrote:
> >
> > +#include <linux/stddef.h>
> > +#include <linux/kernel.h>
> > +#include <linux/delay.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/seq_file.h>
> > +
> > +#include <asm/machdep.h>
> > +#include <asm/prom.h>
> > +#include <asm/system.h>
> > +#include <linux/time.h>
> > +#include <asm/time.h>
> > +#include <linux/kexec.h>
> 
> Normally we don'y mix linux/ and asm/ includes (put all the linux ones at
> the top).
> 
> You need to include <linux/of.h> because you use the device tree accessor
> functions.
> 
Sorry, I made the mistake when correcting a few checkpatch.pl warnings.
I will fix that and re-submit.

Thanks,

Remi




More information about the Linuxppc-dev mailing list