[PATCH 3/5] powerpc: C2K board driver

Stephen Rothwell sfr at canb.auug.org.au
Fri May 16 14:46:45 EST 2008


Hi Remi,

On Thu, 15 May 2008 17:24:28 -0700 Remi Machet <rmachet at slac.stanford.edu> wrote:
>
> +#include <linux/stddef.h>
> +#include <linux/kernel.h>
> +#include <linux/delay.h>
> +#include <linux/interrupt.h>
> +#include <linux/seq_file.h>
> +
> +#include <asm/machdep.h>
> +#include <asm/prom.h>
> +#include <asm/system.h>
> +#include <linux/time.h>
> +#include <asm/time.h>
> +#include <linux/kexec.h>

Normally we don'y mix linux/ and asm/ includes (put all the linux ones at
the top).

You need to include <linux/of.h> because you use the device tree accessor
functions.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080516/2d428579/attachment.pgp>


More information about the Linuxppc-dev mailing list