[PATCH 1/4 V2] booting-without-of for Freescale MSI
Jason.Jin at freescale.com
Fri May 9 20:18:52 EST 2008
> -----Original Message-----
> From: Segher Boessenkool [mailto:segher at kernel.crashing.org]
> Sent: Friday, May 09, 2008 6:14 PM
> To: Jin Zhengxiong
> Cc: michael at ellerman.id.au; linuxppc-dev at ozlabs.org;
> galak at kernel.crashing.org
> Subject: Re: [PATCH 1/4 V2] booting-without-of for Freescale MSI
> >> If these MSI devices work really identical for 83xx, 85xx, 86xx,
> >> there is no need to distinguish between them for probing either --
> >> you want to use the same driver for all, anyway
> > .
> > The driver can work for 83xx, 85xx and 86xx, but the msiir
> offset is
> > different for 83xx and 85xx/86xx cpu. I need this to get different
> > msiir offset in the driver.
> It's a different offset _within_ the region specified in "reg"?
> Yeah, using different "compatible" is cleanest then, no doubt.
Yes, It's different offset _within_ the "reg" region.
> >>> + - msi-available-ranges: use <start count> style
> >> section to define
> >>> which
> >>> + msi interrupt can be used in the 256 msi interrupts.
> >> Please make this property optional, default to "all available".
> > The value setting for this property is "all available", and this
> > ranges maybe useful for some other MSI controller.
> Sure, I didn't say to drop the property, just make it
> optional, since most trees will want the same value anyway.
So, The code should change to work with this change, If there's the
property, use it. If no, make it all available, Am I right?
More information about the Linuxppc-dev