[PATCH 1/4 V2] booting-without-of for Freescale MSI

Segher Boessenkool segher at kernel.crashing.org
Fri May 9 20:13:37 EST 2008


>> If these MSI devices work really identical for 83xx, 85xx,
>> 86xx, there is no need to distinguish between them for
>> probing either -- you want to use the same driver for all, anyway
> .
> The driver can work for 83xx, 85xx and 86xx,  but the msiir offset
> is different for 83xx and 85xx/86xx cpu. I need this to get different
> msiir offset in the driver.

It's a different offset _within_ the region specified in "reg"?
Yeah, using different "compatible" is cleanest then, no doubt.

>>> +    - msi-available-ranges: use <start count> style
>> section to define
>>> which
>>> +      msi interrupt can be used in the 256 msi interrupts.
>>
>> Please make this property optional, default to "all available".
>>
> The value setting for this property is "all available", and this ranges
> maybe
> useful for some other MSI controller.

Sure, I didn't say to drop the property, just make it optional,
since most trees will want the same value anyway.


Segher




More information about the Linuxppc-dev mailing list