[PATCH 10/11] celleb: add support for PCI Express

[Arnd Bergmann]

On Wednesday 05 March 2008, Ishizaki Kou wrote:
> This patch adds support for PCI Express port on Celleb. I/O space
> of this PCI Express port is not mapped in memory space. So we use
> the io-workaround mechanism to make accesses indirect.
> 
> Signed-off-by: Kou Ishizaki <kou.ishizaki at toshiba.co.jp>

Acked-by: Arnd Bergmann <arnd at arndb.de>

This one looks good, but I wonder if we should make it possible to
also use it on QS20, which the current code doesn't allow.

It's a rather hypothetical question, because QS20 has been replaced
by QS21 as a product and it never supported PCIe cards with I/O space
mappings, but it would be the "right" thing to do.

Since you don't have the QS20 hardware to test that, and I currently
doubt anyone at IBM has the energy to do the work, it will probably
never get done. If you send another version of the patch, maybe you
can add comments to hint that this is actually possible, just hasn't
been implemented.