[PATCH 1/9] powerpc: Fix msr setting in 32 bit signal code

Kumar Gala galak at kernel.crashing.org
Tue Jun 24 00:46:15 EST 2008


On Jun 23, 2008, at 2:38 AM, Michael Neuling wrote:

> If we set the SPE MSR bit in save_user_regs we can blow away the VEC
> bit.  This will never happen in reality (VMX and SPE will never be in
> the same processor as their opcodes overlap), but it looks bad.  Also
> when we add VSX here in a later patch, we can hit two of these at the
> same time.
>
> Signed-off-by: Michael Neuling <mikey at neuling.org>
> ---

I think it would also be good to comment about how this doesn't happen  
since they are the same MSR bit.  Having that comment might reduce  
confusion if anyone ever looks at this commit message in the future.   
(Plus you seem to have trailing white space in the commit message).

- k




More information about the Linuxppc-dev mailing list