[PATCH] fs_enet: restore promiscuous and multicast settings in restart()
Vitaly Bordug
vbordug at ru.mvista.com
Fri Jun 20 04:20:42 EST 2008
On Wed, 18 Jun 2008 22:45:57 +0400
"Matvejchikov Ilya" <matvejchikov at gmail.com> wrote:
> I'm glad that you have corrected it. Half a year ago I pointed out
> that there was such a mistake:
> http://patchwork.ozlabs.org/linuxppc/patch?id=10700
>
You've used -embedded ML, and patch wasn't noticed... I can add your S-O-B line if that will make you fill better :)
-Vitaly
> Thanks.
>
> 2008/6/18 Laurent Pinchart <laurentp at cse-semaphore.com>:
> > The restart() function is called when the link state changes and resets
> > multicast and promiscous settings. This patch restores those settings at the
> > end of restart().
> >
> > Signed-off-by: Laurent Pinchart <laurentp at cse-semaphore.com>
> > ---
> > drivers/net/fs_enet/mac-fcc.c | 3 +++
> > 2 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c
> > index ce40cf9..1a95cf1 100644
> > --- a/drivers/net/fs_enet/mac-fcc.c
> > +++ b/drivers/net/fs_enet/mac-fcc.c
> > @@ -464,6 +464,9 @@ static void restart(struct net_device *dev)
> > C32(fccp, fcc_fpsmr, FCC_PSMR_FDE | FCC_PSMR_LPB);
> >
> > S32(fccp, fcc_gfmr, FCC_GFMR_ENR | FCC_GFMR_ENT);
> > +
> > + /* Restore multicast and promiscous settings */
> > + set_multicast_list(dev);
> > }
> >
> > static void stop(struct net_device *dev)
> > --
> > 1.5.0
> >
> > --
> > Laurent Pinchart
> > CSE Semaphore Belgium
> >
> > Chaussee de Bruxelles, 732A
> > B-1410 Waterloo
> > Belgium
> >
> > T +32 (2) 387 42 59
> > F +32 (2) 387 42 75
> >
--
Sincerely,
Vitaly
More information about the Linuxppc-dev
mailing list