[RFC] Kprobes for book-e

Kumar Gala galak at kernel.crashing.org
Fri Jun 20 02:44:44 EST 2008


On Jun 17, 2008, at 8:31 AM, Sulibhavi, Madhvesh wrote:

> Sulibhavi, Madhvesh wrote on Thursday, June 12, 2008 7:59 PM
>>>> static void __kprobes prepare_singlestep(struct kprobe *p, struct
>>>> pt_regs *regs)
>>>> {
>>>> +#ifdef CONFIG_BOOKE
>>>> +	regs->msr &= ~(MSR_EE); /* Turn off 'Externel Interrupt' bits */
>>>> +	regs->msr &= ~(MSR_CE); /* Turn off 'Critical Interrupt' bits */
>>>> +	regs->msr |= MSR_DE;
>>>
>>> can we remove MSR_EE and MSR_CE here?
>>
>> Ah! yes?
>
> No!!, this code cannot be removed. My tests fail
> while doing the probe test for do_gettimeofday and __kmalloc.
> I get Oops and Segfault. I think i had got similar results
> in my initial port using 2.6.26.39. Here is the log...

What is that test.  Can you send it to me.  Its not clear to me why  
this is an issue.

- k



More information about the Linuxppc-dev mailing list