[PATCH] [8xx] powerpc: Add support for the MPC852 based mgsuvd board from keymile.

[Stephen Rothwell]

Hi Heiko,

On Fri, 13 Jun 2008 21:56:00 +0200 Heiko Schocher <hs at denx.de> wrote:
>
> +++ b/arch/powerpc/platforms/8xx/mgsuvd.c
> @@ -0,0 +1,93 @@
> +/* arch/powerpc/platforms/8xx/mgsuvd.c

We have stopped putting file names in files.

> +#include <linux/ioport.h>
> +#include <linux/device.h>
> +#include <linux/of_platform.h>
> +
> +#include <asm/io.h>
> +#include <asm/machdep.h>
> +#include <asm/processor.h>
> +#include <asm/system.h>
> +#include <asm/cpm1.h>
> +#include <asm/fs_pd.h>

I am petty sure you don't need to include linux/device.h, but you should
include asm/prom.h for the flat device tree accessors.

Also, we don't put a space between a function name and the opening
parenthesis.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080614/6465799e/attachment.pgp>