[PATCHv2 1/2] [POWERPC] CPM2: Implement GPIO LIB API on CPM2 Freescale SoC.
laurentp at cse-semaphore.com
Sat Jun 14 01:15:56 EST 2008
On Friday 13 June 2008 16:57, Anton Vorontsov wrote:
> On Fri, Jun 13, 2008 at 02:46:20PM +0200, Laurent Pinchart wrote:
> > On Friday 18 April 2008 19:16, Jochen Friedrich wrote:
> > > Based on earlier work by Laurent Pinchart.
> > >
> > > This patch implement GPIO LIB support for the CPM2 GPIOs.
> > >
> > > Signed-off-by: Jochen Friedrich <jochen at scram.de>
> > > Cc: Laurent Pinchart <laurentp at cse-semaphore.com>
> > Signed-off-by: Laurent Pinchart <laurentp at cse-semaphore.com>
> > Is there any showstopper or can this one be applied to powerpc-next ?
> One comment below.
> > > + mm_gc->save_regs = cpm2_gpio32_save_regs;
> > > + of_gc->gpio_cells = 1;
> I would strongly suggest to use gpio_cells = 2, otherwise you will not
> able to pass GPIO flags (such as active-low etc) without breaking the
> compatibility with older trees.
Agreed. Jochen, will you resubmit or should I do it ?
CSE Semaphore Belgium
Chaussee de Bruxelles, 732A
T +32 (2) 387 42 59
F +32 (2) 387 42 75
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the Linuxppc-dev