[PATCH] [POWERPC] Xilinx: add compatibility for 'simple-bus'.

[Stephen Neuendorffer]

legacy_serial identifies a valid ns16550 on a simple-bus, but the
legacy_serial driver doesn't understand the shift and offset flags
necessary to get it to work, which results in no console.

I think the easiest solution is to change the Kconfig so that
PPC_UDBG_16550 is only selected based on !XILINX_VIRTEX.  I've done this
in my tree, but I've been swamped with other things at the moment, so I
haven't verified it.

Or is legacy_serial just legacy at this point and can go away entirely?
I got the impression from some of the earlier discussion that it wasn't
preferred, at least....

Steve

> -----Original Message-----
> From: glikely at secretlab.ca [mailto:glikely at secretlab.ca] On Behalf Of
Grant Likely
> Sent: Friday, June 06, 2008 8:29 AM
> To: Stephen Neuendorffer
> Cc: dwg at au1.ibm.com; jwboyer at linux.vnet.ibm.com;
linuxppc-dev at ozlabs.org; git
> Subject: Re: [PATCH] [POWERPC] Xilinx: add compatibility for
'simple-bus'.
> 
> On Tue, Jun 3, 2008 at 3:41 PM, Stephen Neuendorffer
> <stephen.neuendorffer at xilinx.com> wrote:
> >
> > It appears that this turns out to interact badly with the probing of
> > PPC_UDBG_16550, which is always enabled on PPC405 (and apparently
> > found!) even though Virtex devices don't have them.
> 
> What is the symptom?
> 
> g.
> 
> >
> > Steve
> >
> >> -----Original Message-----
> >> From: Stephen Neuendorffer [mailto:stephen.neuendorffer at xilinx.com]
> >> Sent: Thursday, May 08, 2008 11:25 AM
> >> To: dwg at au1.ibm.com; jwboyer at linux.vnet.ibm.com;
> > grant.likely at secretlab.ca; linuxppc-dev at ozlabs.org
> >> Cc: Stephen Neuendorffer
> >> Subject: [PATCH] [POWERPC] Xilinx: add compatibility for
'simple-bus'.
> >>
> >> ePAPR drafts propose 'simple-bus' as a generic compatibility type
for
> >> busses which cannot be probed for devices.  In addition, the Xilinx
> >> versions of these IPs seem to be proliferating.  Hence, in the
future
> >> let's prefer to use the standard names.  I've left the old names in
> >> for short term backward compatibility for existing device trees.
> >>
> >> Signed-off-by: Stephen Neuendorffer
<stephen.neuendorffer at xilinx.com>
> >> ---
> >>  arch/powerpc/platforms/40x/virtex.c |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/powerpc/platforms/40x/virtex.c
> > b/arch/powerpc/platforms/40x/virtex.c
> >> index 6c72994..b1ab7b8 100644
> >> --- a/arch/powerpc/platforms/40x/virtex.c
> >> +++ b/arch/powerpc/platforms/40x/virtex.c
> >> @@ -16,6 +16,7 @@
> >>  #include <asm/xilinx_intc.h>
> >>
> >>  static struct of_device_id xilinx_of_bus_ids[] __initdata = {
> >> +     { .compatible = "simple-bus", },
> >>       { .compatible = "xlnx,plb-v46-1.00.a", },
> >>       { .compatible = "xlnx,plb-v46-1.02.a", },
> >>       { .compatible = "xlnx,plb-v34-1.01.a", },
> >> --
> >> 1.5.3.4
> 
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.