Default flats for running dtc from kernel build
Kumar Gala
galak at kernel.crashing.org
Sat Jun 7 01:42:01 EST 2008
On Jun 6, 2008, at 10:31 AM, Jon Loeliger wrote:
> On Fri, 2008-06-06 at 09:51 -0500, Kumar Gala wrote:
>
>>>
>>> I will. But wouldn't it make sense to allow at least for some
>>> level
>>> of compatibility with older versions of U-Boot? Adding these
>>> options
>>> as default would probably not hurt?
>>
>> Agreed. I didn't realize we could actually do this from the kernel
>> build system.
>>
>> I'm sure others will have their two cents to add.
>>
>> But something like:
>>
>> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
>> index c40fb82..52db85a 100644
>> --- a/arch/powerpc/boot/Makefile
>> +++ b/arch/powerpc/boot/Makefile
>> @@ -29,6 +29,8 @@ ifdef CONFIG_DEBUG_INFO
>> BOOTCFLAGS += -g
>> endif
>>
>> +DTS_FLAGS ?= -R4 -S 0x3000
>> +
>> ifeq ($(call cc-option-yn, -fstack-protector),y)
>> BOOTCFLAGS += -fno-stack-protector
>> endif
>
> Hrm. Should we use -p <extra_space> instead of -S <total_space>?
> Seems someone added this DTC commit last November:
>
> commit 2b7dc8dce549ad72ad437b254bf756d7ba4c2a5a
> Author: Kumar Gala <galak at kernel.crashing.org>
> Date: Wed Nov 28 10:21:12 2007 -0600
>
> Add an option to pad the blob that is generated
>
> There are times when we need extra space in the blob and
> just want
> to have it added on w/o know the exact size to make it.
>
> The padding and min size options are mutually exclusive.
>
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
>
> A thought,
> jdl
>
Yeah, I think the -R isn't need either.
So maybe:
DTS_FLAGS ?= -P 0x1000
1k seems like more than enough default padding.
- k
More information about the Linuxppc-dev
mailing list