[RFC] Make board force selection of PHYLIB

[Andy Fleming]

On Jun 3, 2008, at 10:31, Kumar Gala wrote:

>
> On Jun 3, 2008, at 10:18 AM, Scott Wood wrote:
>>
>> If you just #ifdef PHYLIB, then things will break if the user does  
>> this:
>> make config, GIANFAR=PHYLIB=n
>> make zImage
>> make config, GIANFAR=PHYLIB=m
>> make modules
>>
>> And the cause of the failure will not be something that obviously  
>> points to a build problem, such as unresolved symbols.
>
> what you are suggesting will not break with my patch.
>
> The second case will for PHYLIB=y w/the select.
>
>> I'd rather just unconditionally select PHYLIB on platforms that  
>> need to do fixups.
>
> But you don't need fix ups for the phy if you don't have the enet  
> driver that the phy is connected to in your system.
>
> (But I do understand the desire to be generous, but I think we can  
> get this right).


Nonono.  You can't make that code depend on GIANFAR.  Remember, the  
8568 has eTSECs *and* UCCs.  I'm in favor of selecting the PHYLIB  
unconditionally.  But if you really hate that, then at least select it  
based on *either* of those drivers being enabled.