[RFC] Kprobes for book-e
Ananth N Mavinakayanahalli
ananth at in.ibm.com
Tue Jun 3 15:48:46 EST 2008
On Tue, Jun 03, 2008 at 12:30:51AM -0500, Kumar Gala wrote:
> This is a patch that adds kprobes support for book-e style debug. Its
> based on the patch posted by Madhvesh and assumes the exception cleanup
> that I've already posted.
>
> Post to get any feedback. The code needs some cleaning up but wanted to
> see if there were any initial comments.
>
> - k
...
> @@ -53,7 +68,8 @@ int __kprobes arch_prepare_kprobe(struct kprobe *p)
> ret = -EINVAL;
> }
>
> - /* insn must be on a special executable page on ppc64 */
> + /* insn must be on a special executable page on ppc64. This is
> + * explicitly required on ppc32 (right now), but it doesn't hurt */
^^^^^^^^
not required?
I don't have much (any) knowledge about Book-E details, but the generic
powerpc changes look fine to me.
Ananth
More information about the Linuxppc-dev
mailing list