[PATCH] [POWERPC] Cleanup mpic nodes in .dts

Kumar Gala galak at kernel.crashing.org
Tue Jun 3 09:07:09 EST 2008


On Jun 2, 2008, at 11:32 AM, Segher Boessenkool wrote:

>>>> Removed clock-frequency and big-endian props as they aren't  
>>>> specified
>>>> anywhere.
>>>
>>> If you remove "big-endian", you'll have to provide some other way
>>> to get that information (like, some new "compatible" value).
>>
>> I'm all for "big-endian" but we don't spec this anywhere and aren't  
>> using it right now.  So until we have an real need to start an  
>> extended mpic definition I'm getting rid of it.
>
> If we would remove everything insufficiently documented, not much  
> would
> be left.  This doesn't seem very productive to me.  Could you instead
> just add some TODO somewhere?

we were already inconsistent here so I've made all things equal and  
baselined.

>>> Dunno if we need "clock-frequency".
>>
>> Not used today.
>
> Sure, the kernel might not use it today, but that's no reason to  
> remove
> stuff from the device tree.
>
> I'm not against removing "clock-frequency" though, it's not well- 
> defined,
> and what would it be useful for anyway?

As Scott pointed it it could be used for the frequency of the timers  
that exist in OpenPIC.

>>> This patch also removes "built-in" properties.  I'm all for that,
>>> but the patch description didn't say it does.
>>>
>> will add that to the commit message.
>
> Thanks.

I'm sticking to removing the cruft and if/when we need it some can add  
it properly.

- k



More information about the Linuxppc-dev mailing list