[PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver

Evgeniy Polyakov johnpol at 2ka.mipt.ru
Tue Jun 3 03:57:51 EST 2008


On Mon, Jun 02, 2008 at 11:50:21AM -0500, Kim Phillips (kim.phillips at freescale.com) wrote:
> > But can it be changed? You write to it without lock, but read under the
> > one (different for each channel though), so it attracted attention.
> 
> can you point where in the code your concern is?

talitos_submit() writes to hdr (initially I think?) without locks.
It is read in flush_channel() under tail lock, but then it is dropped,
so I rised a question, if it can be modified during that time, since if
it can, status value, calculated from it, can be different and thus
error check result can be false. Or this is not an issue?

-- 
	Evgeniy Polyakov



More information about the Linuxppc-dev mailing list