[PATCH 5/6] Add OF-tree support to RapidIO controller driver.

Zhang Wei Wei.Zhang at freescale.com
Mon Feb 18 18:24:30 EST 2008


 

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org] 
> 
> 
> On Feb 4, 2008, at 11:44 PM, Stephen Rothwell wrote:
> 
> >>
> >> +	aw = *(u32 *)of_get_property(dev->node, "#address-cells", NULL);
> >> +	sw = *(u32 *)of_get_property(dev->node, "#size-cells", NULL);
> >
> > What happens if either of these properties is missing?
> 
> Should we add __must_check to of_get_property?
> 

You are right, I'll add the checking here.

Thanks!
Wei.



More information about the Linuxppc-dev mailing list