On Feb 4, 2008, at 11:44 PM, Stephen Rothwell wrote: >> >> + aw = *(u32 *)of_get_property(dev->node, "#address-cells", NULL); >> + sw = *(u32 *)of_get_property(dev->node, "#size-cells", NULL); > > What happens if either of these properties is missing? Should we add __must_check to of_get_property? - k