[PATCH 1/2] POWERPC/fsl-pci: Better ATMU setup

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Dec 18 07:59:11 EST 2008


On Wed, 2008-12-17 at 11:43 -0800, Trent Piepho wrote:
The default ATMU window can support a pci_mem_offset less than zero too,
but pci_mem_offset is unsigned.  One could say the abilities allowed a
powerpc pci_controller is neither subset nor a superset of the abilities of
a Freescale PCIe controller.  Thankfully, the most useful bits are in the
intersection of the two abilities.

That sign issue shouldn't be too hard to fix if there's a real need by
making sure everything is unsigned and of the same width, in which case,
an addition with the unsigned pci_mem_offset will properly result in a
substraction of the later is negative, even when everybody is
unsigned :-)

But I don't see any pressing need for that.

Ben.





More information about the Linuxppc-dev mailing list