[PATCH] IB/ehca: Allocate event queue size depending on max number of CQs and QPs
Roland Dreier
rdreier at cisco.com
Wed Apr 30 02:43:42 EST 2008
>
> Signed-off-by: Stefan Roscher <stefan.roscher at de.ibm.com>
Kind of an inadequate changelog ;)
Is this a fix or an enhancement or what?
> + if (atomic_read(&shca->num_cqs) >= ehca_max_cq) {
> + if (atomic_read(&shca->num_qps) >= ehca_max_qp) {
These are racy in the sense that multiple simultaneous calls to
create_cq/create_qp might end up exceeding the ehca_max_cq limit. Is
that an issue?
You could close the race by using atomic_add_unless() and testing the
return value (and being careful to do atomic_dec() on error paths after
you bump num_cqs/num_qps).
- R.
More information about the Linuxppc-dev
mailing list