[RESEND][PATCH 1/2][POWERPC] PIKA Warp: Update platform code tosupportRev B boards

Sean MacLennan smaclennan at pikatech.com
Tue Apr 29 15:42:08 EST 2008


On Tue, 29 Apr 2008 15:08:29 +1000
"Paul Mackerras" <paulus at samba.org> wrote:

> It doesn't help that both of these patches have the same subject line,
> nor that it starts with "Re:". :(

Sorry about that. I just split up the two patches, but the same subject
does apply to both. The code currently in the mainline kernel is for a
Rev A. Since there are no Rev As outside of PIKA, that is not very
useful. These patches bring the platform code up to Rev B standards
(while still maintaining Rev A support).

So the subject is correct for both.

> Also, I find the statement "A change to the dts to get gpios correct
> broke the led code" a bit opaque.  It doesn't tell me in what way it
> was broken or what this patch does to correct, or even what the change
> was in enough detail that I could find the change in the git
> repository.

You won't find it. One of the problems is that I am basically adding
patches to patches to patches, but since none of them are in a
mainline git, they all just keep showing up as one big patch. 

That comment was meant as a quick note to explain why the platform patch
changed from the previous platform patch. Short of diffing the
patches, you can't easily see how they changed.

After the Warp is released (sometime in May), the hardware churn should
end and I can submit patches one at a time rather than one massive
patch.

Cheers,
   Sean



More information about the Linuxppc-dev mailing list