[RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

Sean MacLennan smaclennan at pikatech.com
Mon Apr 28 12:25:14 EST 2008


On Sun, 27 Apr 2008 19:51:57 -0600
"Grant Likely" <grant.likely at secretlab.ca> wrote:

> Actually, it looks like he's trying to find the second gpio node in
> the tree.

Correct.

> Sean, if that is true, then this is a very fragile way to do it.
> Really, you should have a phandle somewhere that points to the GPIO
> node that your LEDs are attached to.  Others have been addressing the
> same problem and the consensus seems to be to add a 'leds' node for
> each of your leds with a phandle and gpio descriptor to the gpio node.
> 
> See the documentation added by this patch (section 't'):
> http://patchwork.ozlabs.org/linuxppc/patch?id=18156

I saw that earlier. I thought that that method relied on the gpio_led
driver? I want to use the gpio_led driver, but I believe the underlying
gpio code for the 440EP is not done yet.

If *either* assumption is wrong, let me know! It would be one less
driver (the warp_led driver) that I would have to support outside the
mainline kernel.

I believe, if the platform update gets accepted, that in 2.6.26 the
Warp will be usable with the the mainline kernel. You will just lose
some functionally, such as the SD driver which has already been
rejected.

Cheers,
   Sean



More information about the Linuxppc-dev mailing list