[RESEND][PATCH][POWERPC] PIKA Warp: Update platform code to supportRev B boards

Stephen Rothwell sfr at canb.auug.org.au
Mon Apr 28 10:58:59 EST 2008


Hi Sean,

On Sun, 27 Apr 2008 15:25:46 -0400 Sean MacLennan <smaclennan at pikatech.com> wrote:
>
> +++ b/arch/powerpc/platforms/44x/warp-nand.c
> @@ -11,8 +11,10 @@
>  #include <linux/mtd/partitions.h>
>  #include <linux/mtd/nand.h>
>  #include <linux/mtd/ndfc.h>
> +#include <linux/of_platform.h>

You really want linux.of.h (unless there was some preexisting reason to
require of_platform.h).

> +static void pika_setup_critical_temp(struct i2c_client *client)
> +{
> +	struct device_node *np;
> +	int irq, rc;
> +
> +	/* Setup power LEDS for possible critical temp */
> +	np = of_find_compatible_node(NULL, NULL, "ibm,gpio-440EP");
> +	if (np)
> +		np = of_find_compatible_node(np, NULL, "ibm,gpio-440EP");

Did you really mean to test if (!np) above instead?

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080428/bb472488/attachment.pgp>


More information about the Linuxppc-dev mailing list