[PATCH] MTD: fix partition scan control logic in physmap_of and fsl_elbc_nand

David Woodhouse dwmw2 at infradead.org
Wed Apr 23 04:49:22 EST 2008


On Thu, 2008-02-28 at 20:17 +0800, Li Yang wrote:
> The generic rule for partition scan is to try all supported
> partition types before an usable partition table is found.
> However the original code returns unsuccessful when there is
> an error in any of the partition types.
> 
> Signed-off-by: Li Yang <leoli at freescale.com>
> Cc: Stefan Roese <sr at denx.de>
> Cc: Peter Korsgaard <jacmet at sunsite.dk>
> ---
> I later found that Stefan has proposed a similar patch for physmap_of
> and Peter proposed another patch to fix cmdlinepart instead.
> I'd say that even after cmdlinepart patch is applied the scan control
> logic still needs to be fixed.

I'm not convinced. I think the partition code should return an error if
it hits a hard error, like a failure to read from the device. And return
zero when it doesn't find anything.

-- 
dwmw2




More information about the Linuxppc-dev mailing list