[RFC fs_enet: Convert MII bitbang driver to use GPIO lib

Scott Wood scottwood at freescale.com
Wed Apr 23 01:08:44 EST 2008


On Tue, Apr 22, 2008 at 10:55:06AM +0200, Laurent Pinchart wrote:
> On Monday 21 April 2008 19:56, Scott Wood wrote:
> > The memory-constrained platform I had in mind was 8xx, which doesn't use
> > bitbanged MDIO.  It might nice to keep the gpiolib bit separate to avoid
> > situations such as ep8248e where mdiobb would be the only thing requiring
> > a gpiolib binding, though -- but it shouldn't be two separate bitbang
> > drivers, just the existing bitbang driver plus some glue code that binds
> > it to gpiolib.
> 
> I would be fine with that if the glue code wasn't 90% of the whole driver. 
> There is really little (not to say nothing) that can be shared between the 
> two drivers.

I think we're thinking of a different pair of drivers...  I thought you
were talking about duplicating drivers/net/phy/mdio-bitbang.c, not
drivers/net/fs_enet/mii-bitbang.c.

-Scott




More information about the Linuxppc-dev mailing list