[PATCH 1/3] Raise the upper limit of NR_CPUS.

Tony Breeds tony at bakeyournoodle.com
Tue Apr 22 15:55:36 EST 2008


On Tue, Apr 22, 2008 at 01:50:05PM +1000, Stephen Rothwell wrote:
> Hi Tony,
> 
> On Tue, 22 Apr 2008 13:30:06 +1000 (EST) Tony Breeds <tony at bakeyournoodle.com> wrote:
> >
> > +void __init initialise_pacas(void)
> > +{
> > +	int cpu;
> > +	unsigned long kernel_toc = (unsigned long)(&__toc_start) + 0x8000UL;
> 
> This line could do with a comment saying what it is doing ...

It does need a comment I agree, but I don't think I can do it justice :)
... I just used what was already there.
 
> > +++ b/include/asm-powerpc/paca.h
> >
> > +#if   NR_CPUS >= 32
> > +#define NR_STATIC_PACAS	64
> 
> This allocates 64 pacas etc for NR_CPUS == 32 so surely that test should
> be >?

Yes it should be.

Yours Tony

  linux.conf.au    http://www.marchsouth.org/
  Jan 19 - 24 2009 The Australian Linux Technical Conference!




More information about the Linuxppc-dev mailing list