[PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing
Timur Tabi
timur at freescale.com
Fri Apr 18 08:00:20 EST 2008
Anton Vorontsov wrote:
> static inline bool qe_clock_is_brg(enum qe_clock clk)
> {
> return clk < QE_CLK1;
> }
I have no problem with this function (the UART driver could use it), except that
your implementation is wrong. You would need to do this:
static inline bool qe_clock_is_brg(enum qe_clock clk)
{
return (clk >= QE_BRG1) && (clk <= QE_BRG16);
}
--
Timur Tabi
Linux kernel developer at Freescale
More information about the Linuxppc-dev
mailing list