[PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

Dale Farnsworth dale at farnsworth.org
Fri Apr 18 06:47:20 EST 2008


Timur Tabi wrote:
> Anton Vorontsov wrote:
> 
> > +int qe_usb_clock_set(enum qe_clock clk, int rate)
> > +{
> > +	struct qe_mux __iomem *mux = &qe_immr->qmx;
> > +	unsigned long flags;
> > +	const bool is_brg = clk < QE_CLK1;
> 
> You don't really need "is_brg", since it's only used once.

I find "is_brg" much more meaningful than "clk < QE_CLK1".

Maybe the computer doesn't need it, but it's helpful to a
reader of the code.

-Dale



More information about the Linuxppc-dev mailing list