[PATCH 2/5] [POWERPC] QE: add support for QE USB clocks routing

Scott Wood scottwood at freescale.com
Fri Apr 18 05:59:17 EST 2008


Timur Tabi wrote:
>> +	spin_lock_irqsave(&cmxgcr_lock, flags);
>> +
>> +	clrsetbits_be32(&mux->cmxgcr, QE_CMXGCR_USBCS, val);
> 
> Would it be useful if I made the clrsetbits functions atomic, using lwarx/stwcx.?

No.  clrsetbits operates on I/O registers, not RAM.

-Scott



More information about the Linuxppc-dev mailing list