RFC: MPC5200 PSC AC97 driver

[Juergen Beisert]

On Thursday 17 April 2008 16:23, Matt Sealey wrote:
> Hooray! :)
>
> Does it work, though, with your board?
>
> > -	u16		ccr;		/* PSC + 0x20 */
> > -	u8		reserved7[14];
> > +	u32		ccr;		/* PSC + 0x20 */
> > +	u32		ac97_slots;	/* PSC + 0x24 */
>
> I think it should be left noted here that the CCR size changed from
> 16 bits to 32 bits from 5200 to 5200B in order to reduce confusion.
> You may have read the manual but that does not mean that an extra
> small comment would not be appreciated by a lot of people (after
> all who would want to write code for a legacy 5200 device, write
> to psc->ccr and wonder why it explodes?)

Hmm, my board runs an MPC5200B. How can we solve this u16 versus u32 issue for 
both CPUs?

In the oftree one need somthing like that:

		// PSC1 is ac97
		ac97 at 2000 {
			device_type = "sound";
			compatible = "mpc5200b-psc-ac97","fsl,mpc5200b-psc-ac97";
			cell-index = <0>; // or <1> if it is PSC2! Very important!
			reg = <2000 100>;
			interrupts = <2 2 0>;
			interrupt-parent = <&mpc5200_pic>;
		};

Don't know if it uses the current correct content.

Juergen

-- 
Dipl.-Ing. Juergen Beisert | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
    Handelsregister: Amtsgericht Hildesheim, HRA 2686
         Vertretung Sued/Muenchen, Germany
   Phone: +49-8766-939 228 |  Fax: +49-5121-206917-9