mpc5200: add interrupt type function

Grant Likely grant.likely at secretlab.ca
Thu Apr 17 16:41:08 EST 2008


On Wed, Apr 16, 2008 at 11:00 PM, Robert Schwebel
<r.schwebel at pengutronix.de> wrote:
> On Tue, Apr 15, 2008 at 05:29:54PM +0200, Robert Schwebel wrote:
>  > From: Sascha Hauer <s.hauer at pengutronix.de>
>  >
>  > Add a set_type function for external (GPIO) interrupts.
>  >
>  > Signed-off-by: Juergen Beisert <j.beisert at pengutronix.de>
>  > Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
>
>  As we didn't get negative feedback yet, could this go into the 2.6.26
>  merge window?

I didn't see this the first time (didn't get cc'd).

It looks mostly okay, but in doesn't have any mutual exclusion which
it probably should have.  What are the users of this?

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.



More information about the Linuxppc-dev mailing list