[PATCH] 86xx: mark functions static, other minor cleanups

Kumar Gala galak at kernel.crashing.org
Wed Apr 16 09:01:26 EST 2008


>
> -void
> +static void
> mpc86xx_hpcn_show_cpuinfo(struct seq_file *m)
> {
> 	struct device_node *root;
> @@ -190,13 +190,19 @@ static int __init mpc86xx_hpcn_probe(void)
> {
> 	unsigned long root = of_get_flat_dt_root();
>
> -	if (of_flat_dt_is_compatible(root, "mpc86xx"))
> +	/* Delete this in 2.6.27 */
> +	if (of_flat_dt_is_compatible(root, "mpc86xx")) {
> +		pr_warning("WARNING: your dts/dtb is old. You must update before  
> the next kernel release\n");
> +		return 1;
> +	}
> +
> +	if (of_flat_dt_is_compatible(root, "fsl,mpc8641hpcn"))
> 		return 1;	/* Looks good */
>

how about reversing the order of the checks.

- k


> 	return 0;
> }




More information about the Linuxppc-dev mailing list