fec_mpc5200: reset FEC on error

Kumar Gala galak at kernel.crashing.org
Wed Apr 16 01:29:26 EST 2008


On Apr 15, 2008, at 10:26 AM, Robert Schwebel wrote:
> From: Sascha Hauer <s.hauer at pengutronix.de>
>
> The error handling for the mpc5200 fec interrupt is broken. The  
> intended
> behaviour is like this:
>
> * If one of FEC_IEVENT_RFIFO_ERROR and FEC_IEVENT_XFIFO_ERROR happens,
>  the datasheet says (MPC5200B User's Guide R1.2, p. 14-13): "When this
>  occurs, software must ensure both the FIFO Controller and BestComm  
> are
>  soft-reset".
>
> * On any other error (non-TFINT) interrupt, just issue a debug  
> message.
>
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
>
> ---
> drivers/net/fec_mpc52xx.c |   23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>

You really need to also copy netdev and patches to drivers/net.

- k



More information about the Linuxppc-dev mailing list