[PATCH 09/12] [POWERPC] Move phys_addr_t definition into asm/types.h

Kumar Gala galak at kernel.crashing.org
Wed Apr 16 00:51:46 EST 2008


On Apr 15, 2008, at 5:12 AM, Paul Mackerras wrote:
> Kumar Gala writes:
>
>> Moved phys_addr_t out of mmu-*.h and into asm/types.h so we can use  
>> it in
>> places that before would have caused recursive includes.
>
> ...
>
>> diff --git a/include/asm-powerpc/types.h b/include/asm-powerpc/ 
>> types.h
>> index 903fd19..d853cf0 100644
>> --- a/include/asm-powerpc/types.h
>> +++ b/include/asm-powerpc/types.h
>> @@ -50,6 +50,13 @@ typedef struct {
>> 	__u32 u[4];
>> } __attribute__((aligned(16))) __vector128;
>>
>> +/* Physical address used by some IO functions */
>> +#if defined(CONFIG_PPC64) || defined(CONFIG_PHYS_64BIT)
>> +typedef __u64 phys_addr_t;
>> +#else
>> +typedef __u32 phys_addr_t;
>> +#endif
>
> That appears to be being added in the part of that file that is
> visible to userspace, which isn't a good idea, since phys_addr_t is
> not something we want to export to userspace.
>
> I can fix up the patch when I apply it if you like.

I'll fixup and repost the series.

- k



More information about the Linuxppc-dev mailing list