[PATCH] pseries: phyp dump: Variable size reserve space.

Paul Mackerras paulus at samba.org
Thu Apr 10 11:36:00 EST 2008


Segher Boessenkool writes:

> >>> +	tmp = tmp & ~0x000000001FFFFFFF;
> 
> Note that this only works as you expect because the constant is
> signed here -- the extra zeroes do not magically make it a 64-bit
> number.  So it goes 32-bit 0x1fffffff -> 32-bit -0x20000000 ->
> 64-bit -0x20000000.

Huh?  It's not big enough to be negative when considered as a 32-bit
number...

But yes, adding a UL would be a good idea.

Paul.



More information about the Linuxppc-dev mailing list