[PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth

Benjamin Herrenschmidt benh at ozlabs.org
Wed Apr 9 17:21:34 EST 2008


The iSeries veth driver uses an on-stack struct completion that
it initializes using the COMPLETION_INITIALIZER instead of
COMPLETION_INITIALIZER_ONSTACK macro, causing problems with
lockdep.

Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
---

 drivers/net/iseries_veth.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-work.orig/drivers/net/iseries_veth.c	2008-04-09 13:55:24.000000000 +1000
+++ linux-work/drivers/net/iseries_veth.c	2008-04-09 13:55:48.000000000 +1000
@@ -308,7 +308,8 @@ static void veth_complete_allocation(voi
 
 static int veth_allocate_events(HvLpIndex rlp, int number)
 {
-	struct veth_allocation vc = { COMPLETION_INITIALIZER(vc.c), 0 };
+	struct veth_allocation vc =
+		{ COMPLETION_INITIALIZER_ONSTACK(vc.c), 0 };
 
 	mf_allocate_lp_events(rlp, HvLpEvent_Type_VirtualLan,
 			    sizeof(struct veth_lpevent), number,



More information about the Linuxppc-dev mailing list