[RFC][PATCH] initial port of fixmap over from x86 for ppc32

Paul Mackerras paulus at samba.org
Mon Apr 7 09:48:58 EST 2008


Kumar Gala writes:

> Wanted to get any feedback on this initial port of the fixmap support over
> from x86.  There are a few TODOs:

I have no objection in principle, but your patch below imports a few
things that aren't (and won't be) needed on powerpc AFAICS -- for
example, we don't need FIX_VDSO, since our VDSO is mapped into user
space at the 1MB point (by default).

You have FIX_PCIE_MCFG in there too (keyed off CONFIG_PCI_MMCONFIG
which we don't have and don't want to have).  If you need to map in
PCIe config space, what's wrong with just using ioremap?  Why do you
need to have a fixed virtual address for it?

More generally, I think we need to take an overall look at what things
we are using fixed virtual addresses for, and why they need to be
fixed.  If there are indeed several such things then we can introduce
the fixmap stuff.

Paul.



More information about the Linuxppc-dev mailing list