[Cbe-oss-dev] [PATCH] RTAS - adapt procfs interface

Arnd Bergmann arnd at arndb.de
Fri Apr 4 16:39:29 EST 2008


On Friday 04 April 2008, Christoph Hellwig wrote:
> On Tue, Apr 01, 2008 at 03:12:20PM +0200, Jens Osterkamp wrote:
> > 
> > Hi,
> > 
> > rtas_flash was broken since 2.6.24-rc5. This patch fixes it.
> > I think this is a good bugfix candidate for 2.6.25.
> 
> NACK.  driver should not poke into the internal count member.  Just
> provide your own inclusion with a new counter or set/test_bit.

Well we still have the regression against 2.6.23 and I'd like to
get that fixed in 2.6.25 if it's not already release by the time
we get there.

Would you prefer using Nathan's proper patch for 2.6.25, or do
that for 2.6.26 instead, perhaps using Jens' patch as a quick
fix, as Nathan suggested?

	Arnd <><



More information about the Linuxppc-dev mailing list