[PATCH 1/3][POWERPC][V2] of_serial: Fix possible null dereference.

Josh Boyer jwboyer at linux.vnet.ibm.com
Thu Apr 3 11:56:00 EST 2008


On Thu, 3 Apr 2008 01:39:04 +0200
Arnd Bergmann <arnd at arndb.de> wrote:

> On Wednesday 02 April 2008, Grant Likely wrote:
> > On Wed, Apr 2, 2008 at 10:52 AM, John Linn <john.linn at xilinx.com> wrote:
> > > From: Stephen Neuendorffer <stephen.neuendorffer at xilinx.com>
> > >
> > >  The of_serial driver queries the current-speed property and attempts
> > >  to use it to register the custom_divisor property of the uart_port.
> > >  However, if current-speed is not set, then this code will dereference
> > >  a bad pointer.  The fix is to only set custom_divisor when a
> > >  current-speed property appears in the device tree.
> > >
> > >  Signed-off-by: Stephen Neuendorffer <stephen.neuendorffer at xilinx.com>
> > >  Signed-off-by: John Linn <john.linn at xilinx.com>
> > Acked-by: Grant Likely <grant.likely at secretlab.ca>
> 
> Acked-by: Arnd Bergmann <arnd at arndb.de>

This is the second time all three of us have Acked this.  I'm pulling
it in my tree.

josh



More information about the Linuxppc-dev mailing list