[PATCH 2/3][POWERPC][V2] Xilinx: of_serial support for Xilinx uart 16550.
Grant Likely
grant.likely at secretlab.ca
Thu Apr 3 06:27:38 EST 2008
On Wed, Apr 2, 2008 at 12:20 PM, John Linn <John.Linn at xilinx.com> wrote:
> Sounds good, those are easy changes and make sense.
>
> Since I'm a newbie, I don't know any better sometimes when I copy other
> code that may not be as safe.
>
> The same thing, of_get_property(np, "current-speed", NULL);, is done
> right above my code I added.
>
> Should the other code in the driver using the same method be fixed, or
> just my patch?
It would be good to fix the other code, but not in this patch. Write
another patch to fix that.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
More information about the Linuxppc-dev
mailing list