[PATCH 2/4] [POWERPC] lockdep stacktrace support

[Stephen Rothwell]

On Wed, 02 Apr 2008 18:52:10 +1100 Benjamin Herrenschmidt <benh at ozlabs.org> wrote:
>
> +++ linux-work/arch/powerpc/kernel/stacktrace.c	2008-04-02 16:46:07.000000000 +1100
> @@ -0,0 +1,52 @@
> +

Copyight and license statement needed.

> +#include <linux/sched.h>
> +#include <linux/stacktrace.h>

You should include <asm/ptrace.h> for STACK_FRAME_OVERHEAD and struct pt_regs.

> +#ifdef CONFIG_PPC64
> +#define MIN_STACK_FRAME 112     /* same as STACK_FRAME_OVERHEAD, in fact */

So use STACK_FRAME_OVERHEAD?

> +#define FRAME_LR_SAVE   2
> +#define INT_FRAME_SIZE  (sizeof(struct pt_regs) + STACK_FRAME_OVERHEAD + 288)
                                                     ^^^^^^^^^^^^^^^^^^^^
Its used here already ...

> +#define REGS_MARKER     0x7265677368657265ul

Maybe we need to put REGS_MARKER into a header file as it already appears
in two assembly files and two C files.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080402/5be4a32b/attachment.pgp>