[PATCH 2/8] powerpc: replace `__attribute' by `__attribute__'
Sam Ravnborg
sam at ravnborg.org
Wed Apr 2 05:01:56 EST 2008
On Tue, Apr 01, 2008 at 07:31:01PM +0200, Roel Kluin wrote:
> replace `__attribute' by `__attribute__'
>
> Signed-off-by: Roel Kluin <12o3l at tiscali.nl>
> ---
> diff --git a/arch/powerpc/platforms/iseries/main_store.h b/arch/powerpc/platforms/iseries/main_store.h
> index 1a7a3f5..976b23e 100644
> --- a/arch/powerpc/platforms/iseries/main_store.h
> +++ b/arch/powerpc/platforms/iseries/main_store.h
> @@ -61,7 +61,7 @@ struct IoHriMainStoreSegment4 {
> };
>
> /* Main Store VPD for Power4 */
> -struct __attribute((packed)) IoHriMainStoreChipInfo1 {
> +struct __attribute__((packed)) IoHriMainStoreChipInfo1 {
> u32 chipMfgID;
> char chipECLevel[4];
> };
Please introduce __packed if you touch this.
See include/linux/compiler-gcc.h
This comment is relevant for all your patches.
We have __used and other similar variants.
So take a good look at include/linux/compiler* and
use the proper shortcuts where available.
Sam
More information about the Linuxppc-dev
mailing list