[PATCH] Add idle power save for ppc 4xx

Michael Ellerman michael at ellerman.id.au
Tue Apr 1 14:30:58 EST 2008


On Mon, 2008-03-31 at 22:15 -0500, Josh Boyer wrote:
> On Tue, 2008-04-01 at 12:04 +1100, Michael Ellerman wrote:
> > > > > I'm assuming you pass a dtb to the virtual guest when you start it up.
> > > > > Could you define a property in the CPU node there that can be parsed to
> > > > > use the power_save function instead of always making it the default?
> > > > 
> > > > Actually, you probably don't want this as a property in the device
> > > > tree.  It doesn't describe hardware.  A Kconfig option might be
> > > > warranted though.
> > > 
> > > I'll go with the Kconfig option. 
> > 
> > Go with a device-tree check. The pseries kernel supports both bare-metal
> > and hypervisor in the same kernel image, and it works out which it's
> > running on by looking at the device-tree. This seems equivalent to me?
> 
> After some back and forth on IRC, we decided on that as well.  I love
> being right, then wrong, then right again.
> 
> /me needs more sleep.

Better to be right twice rather than once, no?

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080401/8d517430/attachment.pgp>


More information about the Linuxppc-dev mailing list