2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c

[Kamalesh Babulal]

On 9/20/07, Kamalesh Babulal <kamalesh at linux.vnet.ibm.com> wrote:
>
> Alan Cox wrote:
> > On Thu, 20 Sep 2007 14:13:15 +0100
> > mel at skynet.ie (Mel Gorman) wrote:
> >
> >
> >> PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c .
> It
> >> doesn't show up on other arches because this driver is specific to the
> >> architecture.
> >>
> >> drivers/ata/pata_scc.c: In function `scc_bmdma_status'
> >>
> >
> > Its not been updated to match the libata core changes. Try something
> like
> > this. Whoever is maintaining it should also remove the prereset cable
> handling
> > code and use the proper cable detect method.
> >
> >
> > Signed-off-by: Alan Cox <alan at redhat.com>
> >
> > diff -u --exclude-from /usr/src/exclude --new-file --recursive
> linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_scc.c linux-2.6.23rc6-mm1
> /drivers/ata/pata_scc.c
> > --- linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_scc.c        2007-09-18
> 15:32:51.000000000 +0100
> > +++ linux-2.6.23rc6-mm1/drivers/ata/pata_scc.c        2007-09-20 14:23:
> 32.879807760 +0100
> > @@ -731,7 +731,7 @@
> >       void __iomem *mmio = ap->ioaddr.bmdma_addr;
> >       u8 host_stat = in_be32(mmio + SCC_DMA_STATUS);
> >       u32 int_status = in_be32(mmio + SCC_DMA_INTST);
> > -     struct ata_queued_cmd *qc = ata_qc_from_tag(ap, ap->active_tag);
> > +     struct ata_queued_cmd *qc = ata_qc_from_tag(ap, ap->
> link.active_tag);
> >       static int retry = 0;
> >
> >       /* return if IOS_SS is cleared */
> > @@ -860,10 +860,10 @@
> >   *   @deadline: deadline jiffies for the operation
> >   */
> >
> > -static int scc_pata_prereset(struct ata_port *ap, unsigned long
> deadline)
> > +static int scc_pata_prereset(struct ata_link *link, unsigned long
> deadline)
> >  {
> > -     ap->cbl = ATA_CBL_PATA80;
> > -     return ata_std_prereset(ap, deadline);
> > +     link->ap->cbl = ATA_CBL_PATA80;
> > +     return ata_std_prereset(link, deadline);
> >  }
> >
> >  /**
> > @@ -874,8 +874,9 @@
> >   *   Note: Original code is ata_std_postreset().
> >   */
> >
> > -static void scc_std_postreset (struct ata_port *ap, unsigned int
> *classes)
> > +static void scc_std_postreset (struct ata_link *link, unsigned int
> *classes)
> >  {
> >
> > -     ap->cbl = ATA_CBL_PATA80;
> > -     return ata_std_prereset(ap, deadline);
> > +     link->ap->cbl = ATA_CBL_PATA80;
> > +     return ata_std_prereset(link, deadline);
> >  }
> >
> >  /**
> > @@ -874,8 +874,9 @@
> >   *   Note: Original code is ata_std_postreset().
> >   */
> >
> > +     struct ata_port *ap = link->ap;
> >       DPRINTK("ENTER\n");
> >
> >       /* is double-select really necessary? */
> >
> >
> Hi,
>
> This patch solves the build failure, but with following warnings
> <snip>


sorry, have to fix the mail client, resending the build failure.

Hi,

This patch solves the build failure, but with following warnings
CC drivers/ata/pata_scc.o
drivers/ata/pata_scc.c: In function 'scc_error_handler':
drivers/ata/pata_scc.c:909: warning: passing argument 3 of
'ata_bmdma_drive_eh' from incompatible pointer type

and after that the build fails with

CC [M] drivers/net/spider_net.o
drivers/net/spider_net.c: In function 'spider_net_release_tx_chain':
drivers/net/spider_net.c:818: error: 'dev' undeclared (first use in this
function)
drivers/net/spider_net.c:818: error: (Each undeclared identifier is reported
only once
drivers/net/spider_net.c:818: error: for each function it appears in.)
drivers/net/spider_net.c: In function 'spider_net_xmit':
drivers/net/spider_net.c:922: error: 'dev' undeclared (first use in this
function)
drivers/net/spider_net.c: In function 'spider_net_pass_skb_up':
drivers/net/spider_net.c:1018: error: 'dev' undeclared (first use in this
function)
drivers/net/spider_net.c: In function 'spider_net_decode_one_descr':
drivers/net/spider_net.c:1215: error: 'dev' undeclared (first use in this
function)
make[2]: *** [drivers/net/spider_net.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2


-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20070920/09bde638/attachment.htm>