On 9/20/07, <b class="gmail_sendername">Kamalesh Babulal</b> <<a href="mailto:kamalesh@linux.vnet.ibm.com">kamalesh@linux.vnet.ibm.com</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Alan Cox wrote:<br>> On Thu, 20 Sep 2007 14:13:15 +0100<br>> <a href="mailto:mel@skynet.ie">mel@skynet.ie</a> (Mel Gorman) wrote:<br>><br>><br>>> PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It
<br>>> doesn't show up on other arches because this driver is specific to the<br>>> architecture.<br>>><br>>> drivers/ata/pata_scc.c: In function `scc_bmdma_status'<br>>><br>><br>> Its not been updated to match the libata core changes. Try something like
<br>> this. Whoever is maintaining it should also remove the prereset cable handling<br>> code and use the proper cable detect method.<br>><br>><br>> Signed-off-by: Alan Cox <<a href="mailto:alan@redhat.com">
alan@redhat.com</a>><br>><br>> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_scc.c linux-2.6.23rc6-mm1/drivers/ata/pata_scc.c<br>> --- linux.vanilla-2.6.23rc6-mm1
/drivers/ata/pata_scc.c 2007-09-18 15:32:51.000000000 +0100<br>> +++ linux-2.6.23rc6-mm1/drivers/ata/pata_scc.c 2007-09-20 14:23:32.879807760 +0100<br>> @@ -731,7 +731,7 @@<br>> void __iomem *mmio = ap->
ioaddr.bmdma_addr;<br>> u8 host_stat = in_be32(mmio + SCC_DMA_STATUS);<br>> u32 int_status = in_be32(mmio + SCC_DMA_INTST);<br>> - struct ata_queued_cmd *qc = ata_qc_from_tag(ap, ap->active_tag);
<br>> + struct ata_queued_cmd *qc = ata_qc_from_tag(ap, ap->link.active_tag);<br>> static int retry = 0;<br>><br>> /* return if IOS_SS is cleared */<br>> @@ -860,10 +860,10 @@<br>> * @deadline: deadline jiffies for the operation
<br>> */<br>><br>> -static int scc_pata_prereset(struct ata_port *ap, unsigned long deadline)<br>> +static int scc_pata_prereset(struct ata_link *link, unsigned long deadline)<br>> {<br>> - ap->cbl = ATA_CBL_PATA80;
<br>> - return ata_std_prereset(ap, deadline);<br>> + link->ap->cbl = ATA_CBL_PATA80;<br>> + return ata_std_prereset(link, deadline);<br>> }<br>><br>> /**<br>> @@ -874,8 +874,9 @@<br>
> * Note: Original code is ata_std_postreset().<br>> */<br>><br>> -static void scc_std_postreset (struct ata_port *ap, unsigned int *classes)<br>> +static void scc_std_postreset (struct ata_link *link, unsigned int *classes)
<br>> {<br>><br>> - ap->cbl = ATA_CBL_PATA80;<br>> - return ata_std_prereset(ap, deadline);<br>> + link->ap->cbl = ATA_CBL_PATA80;<br>> + return ata_std_prereset(link, deadline);
<br>> }<br>><br>> /**<br>> @@ -874,8 +874,9 @@<br>> * Note: Original code is ata_std_postreset().<br>> */<br>><br>> + struct ata_port *ap = link->ap;<br>> DPRINTK("ENTER\n");
<br>><br>> /* is double-select really necessary? */<br>><br>><br>Hi,<br><br>This patch solves the build failure, but with following warnings<br><snip></blockquote><div><br>sorry, have to fix the mail client, resending the build failure.
<br></div><br></div>Hi,
<br>
<br>This patch solves the build failure, but with following warnings
<br>CC drivers/ata/pata_scc.o
<br>drivers/ata/pata_scc.c: In function 'scc_error_handler':
<br>drivers/ata/pata_scc.c:909: warning: passing argument 3 of
'ata_bmdma_drive_eh' from incompatible pointer type
<br>
<br>and after that the build fails with
<br>
<br>CC [M] drivers/net/spider_net.o
<br>drivers/net/spider_net.c: In function 'spider_net_release_tx_chain':
<br>drivers/net/spider_net.c:818: error: 'dev' undeclared (first use in this
function)
<br>drivers/net/spider_net.c:818: error: (Each undeclared identifier is
reported only once
<br>drivers/net/spider_net.c:818: error: for each function it appears in.)
<br>drivers/net/spider_net.c: In function 'spider_net_xmit':
<br>drivers/net/spider_net.c:922: error: 'dev' undeclared (first use in this
function)
<br>drivers/net/spider_net.c: In function 'spider_net_pass_skb_up':
<br>drivers/net/spider_net.c:1018: error: 'dev' undeclared (first use in
this function)
<br>drivers/net/spider_net.c: In function 'spider_net_decode_one_descr':
<br>drivers/net/spider_net.c:1215: error: 'dev' undeclared (first use in
this function)
<br>make[2]: *** [drivers/net/spider_net.o] Error 1
<br>make[1]: *** [drivers/net] Error 2
<br>make: *** [drivers] Error 2
<br>
<br>
<br><span class="moz-txt-tag">-- <br></span>Thanks & Regards,
<br>Kamalesh Babulal,
<br>Linux Technology Center,
<br>IBM, ISTL.
<br>
<br>