[PATCH 1/10] spidernet: skb used after netif_receive_skb
Linas Vepstas
linas at austin.ibm.com
Wed May 23 09:09:42 EST 2007
From: Florin Malita <fmalita at gmail.com>
The stats update code in spider_net_pass_skb_up() is touching the skb
after it's been passed up to the stack. To avoid that, just update the
stats first.
Signed-off-by: Florin Malita <fmalita at gmail.com>
Signed-off-by: Linas Vepstas <linas at austin.ibm.com>
----
drivers/net/spider_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c
index 108adbf..1df2f0b 100644
Index: netdev-2.6/drivers/net/spider_net.c
===================================================================
--- netdev-2.6.orig/drivers/net/spider_net.c 2007-05-21 17:40:49.000000000 -0500
+++ netdev-2.6/drivers/net/spider_net.c 2007-05-22 18:03:16.000000000 -0500
@@ -1014,12 +1014,12 @@ spider_net_pass_skb_up(struct spider_net
*/
}
- /* pass skb up to stack */
- netif_receive_skb(skb);
-
/* update netdevice statistics */
card->netdev_stats.rx_packets++;
card->netdev_stats.rx_bytes += skb->len;
+
+ /* pass skb up to stack */
+ netif_receive_skb(skb);
}
#ifdef DEBUG
More information about the Linuxppc-dev
mailing list